Merge pull request #336 from mhy-max/main

fix: av-recorder closing video/audio track export error
bilibili · Dec 6, 2024 · 102d4a3 · 102d4a3
2 parents 93f9787 + 5780270
commit 102d4a3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/.changeset/mean-grapes-bow.md b/.changeset/mean-grapes-bow.md
@@ -0,0 +1,5 @@
+---
+'@webav/av-recorder': patch
+---
+
+fix: av-recorder closing video/audio track export error #335
diff --git a/packages/av-recorder/src/av-recorder.ts b/packages/av-recorder/src/av-recorder.ts
@@ -242,13 +242,20 @@ function startRecord(
   let stopEncodeVideo: TClearFn | null = null;
   let stopEncodeAudio: TClearFn | null = null;
 
+  const [hasVideoTrack, hasAudioTrack] = [
+    opts.streams.video != null,
+    opts.streams.audio != null && opts.audio != null,
+  ];
+
   const recoder = recodemux({
-    video: { ...opts.video, bitrate: opts.bitrate ?? 3_000_000 },
-    audio: opts.audio,
+    video: hasVideoTrack
+      ? { ...opts.video, bitrate: opts.bitrate ?? 3_000_000 }
+      : null,
+    audio: hasAudioTrack ? opts.audio : null,
   });
 
   let stoped = false;
-  if (opts.streams.video != null) {
+  if (hasVideoTrack) {
     let lastVf: VideoFrame | null = null;
     let autoInsertVFTimer = 0;
     const emitVf = (vf: VideoFrame) => {
@@ -290,7 +297,7 @@ function startRecord(
     };
   }
 
-  if (opts.audio != null && opts.streams.audio != null) {
+  if (hasAudioTrack) {
     stopEncodeAudio = autoReadStream(opts.streams.audio, {
       onChunk: async (ad: AudioData) => {
         if (stoped) {