Skip to content

Commit

Permalink
Remove redundant lint rule exclusion
Browse files Browse the repository at this point in the history
Regression caused during upgrade to swiftlint 0.57.0 in the CI
  • Loading branch information
bilaalrashid committed Oct 2, 2024
1 parent d6cd557 commit 07a9cb0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions Tests/BbcNewsTests/BbcNewsTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -60,31 +60,31 @@ final class BbcNewsTests: XCTestCase {

func testConvertWebUrlToApi() throws {
XCTAssertEqual(
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
BbcNews.convertWebUrlToApi(url: URL(string: "https://www.bbc.co.uk/news/uk-politics-68983472.app")!),
URL(string: "https://news-app.api.bbc.co.uk/fd/app-article-api?clientName=Chrysalis&clientVersion=pre-7&page=https://www.bbc.co.uk/news/uk-politics-68983472.app")
)

XCTAssertEqual(
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
BbcNews.convertWebUrlToApi(url: URL(string: "https://www.bbc.co.uk/news/world-europe-18023383.app")!),
URL(string: "https://news-app.api.bbc.co.uk/fd/app-article-api?clientName=Chrysalis&clientVersion=pre-7&page=https://www.bbc.co.uk/news/world-europe-18023383.app")
)

XCTAssertEqual(
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
BbcNews.convertWebUrlToApi(url: URL(string: "https://www.bbc.com/news/articles/c289n8m4j19o.app")!),
URL(string: "https://news-app.api.bbc.co.uk/fd/app-article-api?clientName=Chrysalis&clientVersion=pre-7&page=https://www.bbc.com/news/articles/c289n8m4j19o.app")
)

XCTAssertEqual(
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
BbcNews.convertWebUrlToApi(url: URL(string: "https://www.bbc.co.uk/news/uk-politics-68983472")!),
URL(string: "https://news-app.api.bbc.co.uk/fd/app-article-api?clientName=Chrysalis&clientVersion=pre-7&page=https://www.bbc.co.uk/news/uk-politics-68983472")
)

XCTAssertEqual(
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
BbcNews.convertWebUrlToApi(url: URL(string: "https://bilaal.co.uk")!),
nil
)
Expand Down
6 changes: 3 additions & 3 deletions Tests/BbcNewsTests/FDLinkDestinationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ final class FDLinkDestinationTests: XCTestCase {
func testShareUrl() throws {
let html = FDLinkDestination(
sourceFormat: .html,
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
url: URL(string: "https://www.bbc.com/news/articles/cqenq3e2ld1o")!,
id: "https://www.bbc.com/news/articles/cqenq3e2ld1o",
presentation: FDPresentation(type: .web, contentSource: .bbc)
Expand All @@ -21,7 +21,7 @@ final class FDLinkDestinationTests: XCTestCase {

let legacyAbl = FDLinkDestination(
sourceFormat: .abl,
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
url: URL(string: "https://news-app.api.bbc.co.uk/fd/abl?clientName=Chrysalis&page=uk-politics-68959732&service=news&type=asset")!,
id: "/news/uk-politics-68959732",
presentation: FDPresentation(type: .singleRenderer, canShare: true)
Expand All @@ -30,7 +30,7 @@ final class FDLinkDestinationTests: XCTestCase {

let abl = FDLinkDestination(
sourceFormat: .abl,
// swiftlint:disable:next force_https force_unwrapping
// swiftlint:disable:next force_unwrapping
url: URL(string: "https://news-app.api.bbc.co.uk/fd/app-article-api?page=https%3A%2F%2Fwww.bbc.com%2Farticles%2Fceq3pw038g8o&clientName=Chrysalis&clientVersion=pre-7")!,
id: "https://www.bbc.com/articles/ceq3pw038g8o",
presentation: FDPresentation(type: .singleRenderer, canShare: true)
Expand Down

0 comments on commit 07a9cb0

Please sign in to comment.