Ensure all timestamps for iCal events in UTC #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the classic case of "it worked on my machine", I had erroneously made the assumption that the event timestamps were already in UTC. It looks like that was true, but any of the timestamps that didn't hit the
Date
constructor weren't marked with theZ
. This made the iCal generator library assume they're local, and thus generated with incorrect times.Running each stamp through the date constructor &
toISOString
before passing to the calendar generator should get everything in line as expected!