Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all timestamps for iCal events in UTC #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nitz
Copy link
Contributor

@nitz nitz commented Jan 27, 2025

In the classic case of "it worked on my machine", I had erroneously made the assumption that the event timestamps were already in UTC. It looks like that was true, but any of the timestamps that didn't hit the Date constructor weren't marked with the Z. This made the iCal generator library assume they're local, and thus generated with incorrect times.

Running each stamp through the date constructor & toISOString before passing to the calendar generator should get everything in line as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant