Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Filter hook for Image Size on Cart Items #446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

M4hd1BD
Copy link

@M4hd1BD M4hd1BD commented Nov 13, 2023

What?

Add a filter hook, namely bigcommerce/template/cart_items_image/size, for the IMAGE_SIZE option on the Cart_Items template.

Tickets / Documentation

N/A

Screenshots (if appropriate)

N/A

@karmatosed
Copy link
Collaborator

karmatosed commented Aug 30, 2024

I am along with @bc-erich triaging the queues for PRs and it looks like this one could do with moving on a little. In order to do that I would love to consider if this is something to get into the next release and if so can we get a review. Looping in @chanceaclark for input.

@chanceaclark
Copy link
Contributor

@karmatosed I'm going to be frank here and I'm not sure how filters hooks work in WP. I'd love a little Proof of Life here that it works, otherwise if you think it looks good I'll trust you.

@karmatosed
Copy link
Collaborator

That's absolutely no issue. @M4hd1BD I realise this was a little while ago, would it be possible to get the following from you to confirm this as we seem to be missing some details to your PR.

  1. Before and after screenshots. Specifically showing the filter implemented and where it outputs. If there is any interface change - if not please confirm that.
  2. Testing confirmation.

Aside from that, we do need testing on this to ensure it both works and is still valid since a little time has passed.

@M4hd1BD
Copy link
Author

M4hd1BD commented Sep 19, 2024

Hi @karmatosed, I don't remember if I tested it initially when I did the PR, I must've. Anyway, took me a while to set up the environment but I have tested it again.

  1. There is no interface change. This is mainly for developers, they can change the size of the image supplied on the Cart page. I don't remember why I wanted to do that but I definitely did and didn't want to edit the plugin files directly (because maintainability, its better to extend on the plugin through something like a child theme instead of editing plugin files directly).
  2. I have tested it now again and here is a screen record showing it works. On the screen record, I showed what it is by default and then I applied the filter through the child theme and changed the size and it did change the size.
2024-09-19_23-23-56.mp4

Let me know if you guys need anything else from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants