-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faraday 2 support (update CI and dependencies) #21
Conversation
@bhaberer Would you like to review PRs before merging or do you prefer a more hands-off approach? |
Btw I wasn't expecting all tests to pass with Faraday 2.0 🤔 |
Sorry for the late reply, I just assumed because of the documentation it won't work, I never actually tried it! - I just did and so far it seems to be working, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Glad to hear the current version is working already, we can still merge this and might not even need to release a new major version because |
No objections from me and much appreciated :) |
Summary
This PR refreshes outdated development dependencies and more notably sets Ruby 3.0 as the minimum Ruby version (this will likely warrant a new major release). The reason is that Ruby 3.0 is nearing EOL already, and Faraday 2.0 does not support Ruby 2.7 or earlier.
CI has also been improved to test the correct Ruby versions, as well as adding a dimension to test both Faraday 1.x and 2.x