fix: Moved optimal bandwidth to base forwarder #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
♻️ Forge Gas SnapshotsSeems like you are not measuring gas of any operations yet. 🤔 |
🌈 Test ResultsNo files changed, compilation skipped
2025-02-12T14:54:32.659268Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^0.16.2", "adi-diff-snapshots", "./reports/adi_add_sonic_path_to_adiethereum_before.json", "./reports/adi_add_sonic_path_to_adiethereum_after.json", "-o", "./diffs/adi_add_sonic_path_to_adiethereum_before_adi_add_sonic_path_to_adiethereum_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/aave-cli@0.16.4\nnpm warn deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility\nnpm warn deprecated interface-ipld-format@1.0.1: This module has been superseded by the multiformats module\nnpm warn deprecated cids@1.1.9: This module has been superseded by the multiformats module\nnpm warn deprecated multibase@4.0.6: This module has been superseded by the multiformats module\nnpm warn deprecated multicodec@3.2.1: This module has been superseded by the multiformats module\nnpm warn deprecated ipld-dag-pb@0.22.3: This module has been superseded by @ipld/dag-pb and multiformats\nfile:///home/runner/.npm/_npx/98f577e373727b30/node_modules/@bgd-labs/aave-cli/dist/cli.js:399\nimport { CHAIN_ID_CLIENT_MAP } from \"@bgd-labs/js-utils\";\n ^^^^^^^^^^^^^^^^^^^\nSyntaxError: Named export 'CHAIN_ID_CLIENT_MAP' not found. The requested module '@bgd-labs/js-utils' is a CommonJS module, which may not support all module.exports as named exports.\nCommonJS modules can always be imported via the default export, for example using:\n\nimport pkg from '@bgd-labs/js-utils';\nconst { CHAIN_ID_CLIENT_MAP } = pkg;\n\n at ModuleJob._instantiate (node:internal/modules/esm/module_job:146:21)\n at async ModuleJob.run (node:internal/modules/esm/module_job:229:5)\n at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)\n at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:122:5)\n\nNode.js v20.18.2\n"
Ran 2 tests for tests/payloads/ethereum/AddSonicPathTest.t.sol:EthereumAddSonicPathPayloadTest
[PASS] test_defaultTest() (gas: 1772076)
[PASS] test_samePayloadAddress() (gas: 225232)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 17.77s (17.50s CPU time)
2025-02-12T14:54:32.671935Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^0.16.2", "adi-diff-snapshots", "./reports/adi_add_celo_path_to_adiethereum_before.json", "./reports/adi_add_celo_path_to_adiethereum_after.json", "-o", "./diffs/adi_add_celo_path_to_adiethereum_before_adi_add_celo_path_to_adiethereum_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/aave-cli@0.16.4\nnpm warn deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility\nnpm warn deprecated interface-ipld-format@1.0.1: This module has been superseded by the multiformats module\nnpm warn deprecated cids@1.1.9: This module has been superseded by the multiformats module\nnpm warn deprecated multibase@4.0.6: This module has been superseded by the multiformats module\nnpm warn deprecated multicodec@3.2.1: This module has been superseded by the multiformats module\nnpm warn deprecated ipld-dag-pb@0.22.3: This module has been superseded by @ipld/dag-pb and multiformats\nfile:///home/runner/.npm/_npx/98f577e373727b30/node_modules/@bgd-labs/aave-cli/dist/cli.js:399\nimport { CHAIN_ID_CLIENT_MAP } from \"@bgd-labs/js-utils\";\n ^^^^^^^^^^^^^^^^^^^\nSyntaxError: Named export 'CHAIN_ID_CLIENT_MAP' not found. The requested module '@bgd-labs/js-utils' is a CommonJS module, which may not support all module.exports as named exports.\nCommonJS modules can always be imported via the default export, for example using:\n\nimport pkg from '@bgd-labs/js-utils';\nconst { CHAIN_ID_CLIENT_MAP } = pkg;\n\n at ModuleJob._instantiate (node:internal/modules/esm/module_job:146:21)\n at async ModuleJob.run (node:internal/modules/esm/module_job:229:5)\n at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)\n at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:122:5)\n\nNode.js v20.18.2\n"
Ran 1 test for tests/payloads/ethereum/AddCeloPathTest.t.sol:EthereumAddCeloPathPayloadTest
[PASS] test_defaultTest() (gas: 1673323)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 17.80s (17.50s CPU time)
Ran 3 tests for tests/access_control/GranularGuardianDeployTest.t.sol:ArbitrumGGTest
[PASS] test_initialization() (gas: 214313)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210166, ~: 210166)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12968, ~: 12968)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 18.28s (18.00s CPU time)
Ran 3 tests for tests/access_control/GranularGuardianDeployTest.t.sol:MetisGGTest
[PASS] test_initialization() (gas: 214354)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210207, ~: 210207)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12968, ~: 12968)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 36.63s (36.28s CPU time)
Ran 3 tests for tests/access_control/GranularGuardianDeployTest.t.sol:OptimismGGTest
[PASS] test_initialization() (gas: 214336)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210189, ~: 210189)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12968, ~: 12968)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 13.55s (13.32s CPU time)
Ran 7 tests for tests/access_control/GranularGuardianDeployTest.t.sol:EthereumGGTest
[PASS] test_initialization() (gas: 214857)
[PASS] test_retryEnvelope(address,uint256) (runs: 256, μ: 1963876, ~: 1967509)
[PASS] test_retryEnvelopeWhenWrongCaller(uint256,address) (runs: 256, μ: 14396, ~: 14396)
[PASS] test_retryTx(address,uint256) (runs: 256, μ: 1578890, ~: 1582748)
[PASS] test_retryTxWhenWrongCaller(uint256,address) (runs: 256, μ: 14514, ~: 14514)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210821, ~: 210821)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12990, ~: 12990)
Suite result: ok. 7 passed; 0 failed; 0 skipped; finished in 111.83s (111.56s CPU time)
Ran 5 tests for tests/access_control/GranularGuardianDeployTest.t.sol:GnosisGGTest
[PASS] test_initialization() (gas: 214378)
[PASS] test_solveEmergencyDeprecated() (gas: 424035)
[PASS] test_solveEmergencyDeprecatedWhenWrongCaller(address) (runs: 256, μ: 18137, ~: 18137)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210321, ~: 210321)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12980, ~: 12980)
Suite result: ok. 5 passed; 0 failed; 0 skipped; finished in 48.65s (48.24s CPU time)
Ran 9 tests for tests/access_control/GranularGuardianDeployTest.t.sol:AvalancheGGTest
[PASS] test_initialization() (gas: 214935)
[PASS] test_retryEnvelope(address,uint256) (runs: 256, μ: 1915703, ~: 1919055)
[PASS] test_retryEnvelopeWhenWrongCaller(uint256,address) (runs: 256, μ: 14386, ~: 14386)
[PASS] test_retryTx(address,uint256) (runs: 256, μ: 1604880, ~: 1607348)
[PASS] test_retryTxWhenWrongCaller(uint256,address) (runs: 256, μ: 14549, ~: 14549)
[PASS] test_solveEmergencyDeprecated() (gas: 425143)
[PASS] test_solveEmergencyWhenWrongCallerDeprecated(address) (runs: 256, μ: 18126, ~: 18136)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210920, ~: 210920)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 13002, ~: 13002)
Suite result: ok. 9 passed; 0 failed; 0 skipped; finished in 125.66s (125.32s CPU time)
Ran 3 tests for tests/access_control/GranularGuardianDeployTest.t.sol:ScrollGGTest
[PASS] test_initialization() (gas: 214469)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210280, ~: 210280)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12968, ~: 12968)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 18.66s (18.37s CPU time)
Ran 3 tests for tests/access_control/GranularGuardianDeployTest.t.sol:LineaGGTest
[PASS] test_initialization() (gas: 214538)
[PASS] test_updateGuardian(address) (runs: 256, μ: 207693, ~: 207693)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12968, ~: 12968)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 16.99s (16.77s CPU time)
Ran 3 tests for tests/access_control/GranularGuardianDeployTest.t.sol:CBaseGGTest
[PASS] test_initialization() (gas: 214400)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210211, ~: 210211)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12968, ~: 12968)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 17.35s (17.18s CPU time)
Ran 9 tests for tests/access_control/GranularGuardianDeployTest.t.sol:PolygonGGTest
[PASS] test_initialization() (gas: 214912)
[PASS] test_retryEnvelope(address,uint256) (runs: 256, μ: 1929640, ~: 1932658)
[PASS] test_retryEnvelopeWhenWrongCaller(uint256,address) (runs: 256, μ: 14386, ~: 14386)
[PASS] test_retryTx(address,uint256) (runs: 256, μ: 1547139, ~: 1548790)
[PASS] test_retryTxWhenWrongCaller(uint256,address) (runs: 256, μ: 14549, ~: 14549)
[PASS] test_solveEmergencyDeprecated() (gas: 425097)
[PASS] test_solveEmergencyWhenWrongCallerDeprecated(address) (runs: 256, μ: 18136, ~: 18136)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210897, ~: 210897)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 13002, ~: 13002)
Suite result: ok. 9 passed; 0 failed; 0 skipped; finished in 129.09s (136.38s CPU time)
Ran 5 tests for tests/access_control/GranularGuardianDeployTest.t.sol:BinanceGGTest
[PASS] test_initialization() (gas: 214314)
[PASS] test_solveEmergencyDeprecated() (gas: 423907)
[PASS] test_solveEmergencyDeprecatedWhenWrongCaller(address) (runs: 256, μ: 18137, ~: 18137)
[PASS] test_updateGuardian(address) (runs: 256, μ: 210257, ~: 210257)
[PASS] test_updateGuardianWhenWrongCaller(address,address) (runs: 256, μ: 12980, ~: 12980)
Suite result: ok. 5 passed; 0 failed; 0 skipped; finished in 39.48s (41.93s CPU time)
Ran 13 test suites in 165.18s (611.74s CPU time): 56 tests passed, 0 failed, 0 skipped (56 total tests) |
Forge Build Sizes
🔕 Unchanged
|
🔮 Coverage report
|
kyzia551
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Optimal Bandwidth to BaseForwarder payload creation as virtual, so that if needed we would only need to override with specific bandwidth.