Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a waste line in models/tiramisu.py #21

Open
truebelief opened this issue Aug 11, 2019 · 0 comments
Open

Found a waste line in models/tiramisu.py #21

truebelief opened this issue Aug 11, 2019 · 0 comments

Comments

@truebelief
Copy link

The line 60 in your code, tiramisu.py, : cur_channels_count += prev_block_channels
actually does nothing, since the cur_channels_count is overwritten before and after. Please consider removing it, since it is confusing and misleading.

        #######################
       #   Upsampling path   #
       #######################

       self.transUpBlocks = nn.ModuleList([])
       self.denseBlocksUp = nn.ModuleList([])
       for i in range(len(up_blocks)-1):
           self.transUpBlocks.append(TransitionUp(prev_block_channels, prev_block_channels))
           cur_channels_count = prev_block_channels + skip_connection_channel_counts[i]

           self.denseBlocksUp.append(DenseBlock(
               cur_channels_count, growth_rate, up_blocks[i],
                   upsample=True))
           prev_block_channels = growth_rate*up_blocks[i]
           cur_channels_count += prev_block_channels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant