Build fails with Go 1.24

[stefanb]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

tfproviderlint and terraform-plugin-sdk Version

$ tfproviderlint -version
0.30.0

$ go mod graph | cut -d' ' -f 1 | grep terraform-plugin-sdk | uniq

Affected Check(s) or Function(s)

• AT###

Expected Behavior

Build with Go 1.24 should succeed

Actual Behavior

Build failed.
Log from https://github.com/Homebrew/homebrew-core/actions/runs/13269964591/job/37049618249#step:3:19398 :

  ==> /opt/homebrew/Cellar/tfproviderlint/0.30.0/bin/tfproviderlint -fix /private/tmp/tfproviderlint-test-20250212-44708-kvbskr/... 2>&1
  tfproviderlint: internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom [github.com/russellcardullo/terraform-provider-pingdom/pingdom.test]"
  tfproviderlint: internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom"
  ==> Testing tfproviderlint (again)
  /usr/bin/env tar --extract --no-same-owner --file /Users/brew/Library/Caches/Homebrew/downloads/fccefef3f08b7a820d05ace0b85206451e84a7e7a403095e89d82eca2e9ba8ef--terraform-provider-pingdom-1.1.3.tar.gz --directory /private/tmp/homebrew-unpack-20250212-45333-pscrq4
  mv /private/tmp/homebrew-unpack-20250212-45333-pscrq4/terraform-provider-pingdom-1.1.3 /private/tmp/homebrew-test_resource-20250212-45333-lfdfof/terraform-provider-pingdom-1.1.3
  ==> /opt/homebrew/Cellar/tfproviderlint/0.30.0/bin/tfproviderlint -fix /private/tmp/tfproviderlint-test-20250212-45333-yn5xrd/... 2>&1
  tfproviderlint: internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom [github.com/russellcardullo/terraform-provider-pingdom/pingdom.test]"

References

tfproviderlint/go.mod

Line 7 in 031f7d1

golang.org/x/tools v0.23.0

For Go 1.24 compatibility the golang.org/x/tools module should be bumped to v0.30.0 - https://github.com/golang/tools/releases/tag/v0.30.0

• Found in go 1.24.0, go@1.23 1.23.6 (new formula) Homebrew/homebrew-core#201070

[bflad]

Thank you for raising this, @stefanb! While I didn't submit this as a formula into Homebrew core, I appreciate its already there and want to help unblock the go formula upgrade. I'll see if bumping golang.org/x/tools is enough, but otherwise, I personally don't have any opinions on whether its better or worse to pin it back to 1.23.

This project also is getting close to being archived, if I'm being honest, and if that sways any handling of it in Homebrew core.

[bflad]

I've cut https://github.com/bflad/tfproviderlint/releases/tag/v0.31.0 with that upgrade (along with bumping the minimum to Go 1.22). I'll leave this open until we can confirm Go 1.24 is working as expected -- unfortunately I cannot do that this moment.

[bflad]

In my limited testing, this seems to be working as expected after the update. Please open a new issue if that's not the case. 👍