Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Document VFS #1960

Open
badosu opened this issue Feb 18, 2025 · 4 comments
Open

[Docs] Document VFS #1960

badosu opened this issue Feb 18, 2025 · 4 comments
Labels
area: documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@badosu
Copy link
Collaborator

badosu commented Feb 18, 2025

Basically what it says on the tin, currently we don't document any of VFS.

See: https://github.com/beyond-all-reason/spring/blob/master/rts/Lua/LuaVFS.cpp

@rhys-vdw
Copy link
Collaborator

rhys-vdw commented Feb 18, 2025

NOTE: VFS.Include is an alias of require, which has to be defined in luarc.json, rather than defined inline.

See aliases here: https://github.com/beyond-all-reason/recoil-lua-library/blob/main/README.md?plain=1#L27-L31

Any other methods should be documented (and maybe these too? I'm not sure how it interacts).

@sprunk
Copy link
Collaborator

sprunk commented Feb 18, 2025

NOTE: VFS.Include is an alias of require

No it's not, that's just convenient fiction/approximation so that LuaLS knows how it behaves.

@badosu
Copy link
Collaborator Author

badosu commented Feb 19, 2025

Any other methods should be documented (and maybe these too? I'm not sure how it interacts).

See https://springrts.com/wiki/Lua_VFS as an example (hopefully VFS API hasnt changed a lot?).

@badosu badosu added area: documentation Improvements or additions to documentation good first issue Good for newcomers labels Feb 19, 2025
@rhys-vdw
Copy link
Collaborator

NOTE: VFS.Include is an alias of require

No it's not, that's just convenient fiction...

Yeah I know it's not actually an alias, I set it in the config. It will need to be documented for the site, but I'm not not sure how LLS will resolve the alias vs the doc comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants