Skip to content

Commit

Permalink
Formally undeprecate ScreenshotCounter to keep compat with older engines
Browse files Browse the repository at this point in the history
  • Loading branch information
@lhog
lhog committed Jan 25, 2024
1 parent 723d5f5 commit 759cb14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rts/Rendering/Screenshot.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#undef CreateDirectory

CONFIG(int, ScreenshotCounter).deprecated(true);
CONFIG(int, ScreenshotCounter).description("Deprecated, does nothing, but not marked as such to keep compatibility with older engine versions").defaultValue(0);

struct FunctionArgs
{
Expand Down

2 comments on commit 759cb14

@sprunk
Copy link
Collaborator

@sprunk sprunk commented on 759cb14 Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort of compatibility? Is it just so that running 105-2222 and then going back to 105-1111 all on the same springsettings file won't reset the counter to 0?

@lhog
Copy link
Collaborator Author

@lhog lhog commented on 759cb14 Jan 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort of compatibility? Is it just so that running 105-2222 and then going back to 105-1111 all on the same springsettings file won't reset the counter to 0?

GF:
my screenshot folder is getting screwed up
the engine now dates screenshots rather than numbers them
but the engine also likes deleting springsettings keys all the time
so when I switch to and from test engines, the screenshot number goes away
so to take a screenshot on old engines I have to hold down the screenshot key until I actually take a screenshot
since it won't override existing files
(not overriding is good, its just the last thing that causes a problem in the whole chain of bad things)

Please sign in to comment.