Fixed quests 3908, 3972 & 3973

[sky1683589933]

Add quest execution script 3908 to fix the issue of not being able to complete quest properly, add quest execution script 3972 to fix empty dialog, and add quest execution script 3973 to fix the issue of completing quest without work items and encountering empty dialog.

[neon-dev]

Please take a look at these changes and tell me in case I missed something: 0290ea6
I changed 3972 and 3973 to <report_to_many> handlers and fixed a problem in ReportToMany.java where the quest dialog after accepting the quest would not show.
The only difference between your 3973 Java handler and ReportToMany is that losing a workItem will not reset the quest step. This could be implemented in ReportToMany.java too, but we'd need info if and how the retail server handles this.

[sky1683589933]

Please take a look at these changes and tell me in case I missed something: 0290ea6 I changed 3972 and 3973 to <report_to_many> handlers and fixed a problem in ReportToMany.java where the quest dialog after accepting the quest would not show. The only difference between your 3973 Java handler and ReportToMany is that losing a workItem will not reset the quest step. This could be implemented in ReportToMany.java too, but we'd need info if and how the retail server handles this.

Hi, I think Quest 3973 needs to have a rollback function without any work items, because the final result is to submit three work items. If this function is missing, all three work items can be thrown away to complete the quest. Of course, if the Quest step is executed normally, the rollback code will not be executed at all.

[neon-dev]

Do you know what happens on official servers when you throw away a work item? Is the quest reset immediately, or when talking to the next npc, or only at the reward npc?

[sky1683589933]

Do you know what happens on official servers when you throw away a work item? Is the quest reset immediately, or when talking to the next npc, or only at the reward npc?

No, It is impossible to remember or search for details that are ancient, and can only be inferred through reverse reasoning based on the results. Just my reasoning!
Unless I go to retail again, which is obviously unrealistic, haha! The details cannot be verified. The rollback is only for the purpose of completing the request without submitting the work item in exceptional circumstances. As for the logical step of rollback, I think it is best to immediately rollback when the work item is lost.

[neon-dev]

As for the logical step of rollback, I think it is best to immediately rollback when the work item is lost.

I agree.
Can I merge this pull request in its current state? The detection of discarded work items should be implemented separately, as it is not a small change and will affect all <report_to_many> quests.

[sky1683589933]

I agree. Can I merge this pull request in its current state?
yeah， of course!

[sky1683589933]

I agree. Can I merge this pull request in its current state?
yeah， of course!

oh， I forgot to add an author for the new Java script execution. Although I don't care about this, it looks more formal this way, haha!

[neon-dev]

It's your choice

[sky1683589933]

Please help me add a name: sky123， thank you!