Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of hand-modified allensdk #4

Open
jnsbck opened this issue Aug 1, 2023 · 2 comments
Open

get rid of hand-modified allensdk #4

jnsbck opened this issue Aug 1, 2023 · 2 comments
Labels
upstream

Comments

@jnsbck
Copy link
Contributor

jnsbck commented Aug 1, 2023 •
edited
Loading

A lot of modifications were made to the ephys_extractor.py and ephys_features.py from the AllenSDK. These modifications should be moved / integrated with features.py and added to the extractor via the add_sweep_feature function.
This was referenced Aug 1, 2023
Open
Open
@jnsbck
Copy link
Contributor Author

jnsbck commented Aug 23, 2023

This was partially completed in the rewrite_object_oriented. However due to some bugs in the AllenSDK, this was not entirely succesful. To fix this a PR needs to be made to the AllenSDK.

@jnsbck jnsbck added the upstream label Sep 4, 2023
@jnsbck
Copy link
Contributor Author

jnsbck commented Sep 4, 2023 •
edited
Loading

For details of what changed see git diff main:ephyspy/allen_sdk/ephys_features.py 6691072:py_ephys/allen_sdk/ephys_features.py. Which is the diff between the original and modified AllenSDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

rewrite_object_oriented berenslab/ephyspy
1 participant
@jnsbck