Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak variant position regex & feedback #481

Merged
merged 2 commits into from
Mar 5, 2025
Merged

tweak variant position regex & feedback #481

merged 2 commits into from
Mar 5, 2025

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Mar 5, 2025 •
edited
Loading

Fixes to variant search by position (Redmine #2470):

  • reject non-matches (previously you could add extra cruft as long as the pattern could find chromosome, start and end values)
  • provide user feedback right away about whether their position notation is correct.

davidlougheed
davidlougheed approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit af8ae5e into master Mar 5, 2025
3 checks passed
@gsfk gsfk deleted the fixes/variant-position-regex branch March 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @davidlougheed