Add s3 support to dropbox #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
requested changes
Jan 28, 2025
bento_drop_box_service/config.py
Outdated
| @@ -21,6 +22,14 @@ class Config(BentoFastAPIBaseConfig): | |||
| service_data_source: Literal["local"] = "local" | |||
| traversal_limit: int = 16 | |||
|
|
|||
| use_https: bool = True | |||
| check_ssl_certificate: bool = False | |||
There was a problem hiding this comment.
we have a standard value for this, already configured in the BentoFastAPIBaseConfig base class: https://github.com/bento-platform/bento_lib/blob/master/bento_lib/config/pydantic.py#L30
There was a problem hiding this comment.
(or maybe the context here is different? if so, then maybe put a comment above explaining)
There was a problem hiding this comment.
Since BentoFastAPIBaseConfig.bento_validate_ssl is not used anywhere in drop-box, we can use it for S3 without worrying about side-effects.
added 2 commits
February 13, 2025 13:24
|
@davidlougheed @v-rocheleau The problem with run.bash and run.dev.bash files is fixed. It was a problem with permissions + final new line (thanks David). |
v-rocheleau
requested changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.