drop short self loops on imports

benchmark-urbanism · May 14, 2024 · 0334a50 · 0334a50
1 parent b6e2361
commit 0334a50
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "cityseer"
-version = '4.13.2'
+version = '4.13.3'
 description = "Computational tools for network-based pedestrian-scale urban analysis"
 readme = "README.md"
 requires-python = ">=3.10, <3.13"

diff --git a/pysrc/cityseer/tools/io.py b/pysrc/cityseer/tools/io.py
@@ -1142,10 +1142,13 @@ def _node_key(node_coords: list[float]):
         edge_geom = edge_row[geom_key]
         coords_a = edge_geom.coords[0]
         node_key_a = _node_key(coords_a)
-        if node_key_a not in g_multi:
-            g_multi.add_node(node_key_a, x=coords_a[0], y=coords_a[1])
         coords_b = edge_geom.coords[-1]
         node_key_b = _node_key(coords_b)
+        # drop short self-loops
+        if node_key_a == node_key_b and edge_geom.length < 5:
+            continue
+        if node_key_a not in g_multi:
+            g_multi.add_node(node_key_a, x=coords_a[0], y=coords_a[1])
         if node_key_b not in g_multi:
             g_multi.add_node(node_key_b, x=coords_b[0], y=coords_b[1])
         g_multi.add_edge(node_key_a, node_key_b, momepy_edge_idx=edge_idx, geom=edge_geom)