Remove the DndResources class and have users of this class create a CustomSongResources directly.
#634
Comments
github-actions bot
pushed a commit
that referenced
this issue
Oct 2, 2019
#584, #585, #586, #587, #588, #589, #590, #591, #592, #593, #594, #595, #596, #597, #598, #599, #600, #601, #602, #603, #604, #605, #606, #607, #608, #609, #610, #611, #612, #613, #614, #615, #616, #617, #618, #619, #620, #621, #622, #623, #624, #625, #626, #627, #628, #629, #630, #631, #632, #633, #634, #635, #636, #637, #638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The original implementation of DndResources class has been extracted
into a CustomSongResources superclass in commit cc6a6e7,
so that part of its logic can be re-used in other contexts, such as in commit ba9e15b.
Now this
DndResourcesclass is really dumb and we want to prefer composition over inheritance.This class should be removed.
This issue has been automatically created by todo-actions based on a TODO comment found in src/resources/dnd-resources.ts:8. It will automatically be closed when the TODO comment is removed from the default branch (master).
The text was updated successfully, but these errors were encountered: