Merge pull request #381 from stefanorosanelli/chore/humanize-fields

chore: humanize list field labels
bedita · Jan 30, 2020 · 488407f · 488407f
2 parents c9dfe45 + 4a96d77
commit 488407f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/Template/Element/FilterBox/filter_box_common.twig b/src/Template/Element/FilterBox/filter_box_common.twig
@@ -37,7 +37,7 @@
     {# other dynamic filters #}
     <div v-for="filter in dynamicFilters" class="filter-container" :class="[filter.name, filter.type, filter.date? 'date' : '' ]">
         <input type="hidden" :name="filter.name" :value="filter.value">
-        <div class="filter-label"><: t(filter.name) :></div>
+        <div class="filter-label"><: filter.name | humanize :></div>
 
         <span v-if="filter.type === 'select' || filter.type === 'radio'">
             <select v-model="queryFilter.filter[filter.name]" :id="filter.name" class="{{ selectBaseClasses }}">

diff --git a/src/Template/Pages/Modules/index.twig b/src/Template/Pages/Modules/index.twig
@@ -21,10 +21,10 @@
                 {% endfor %}
                 <div>{{ Link.sort('id')}}</div>
                 {% if currentModule.hints.multiple_types %}
-                    <div>{{ __('type') }}</div>
+                    <div>{{ __('Type') }}</div>
                 {% endif %}
 
-                <div>{{ __('status') }}</div>
+                <div>{{ __('Status') }}</div>
                 <div>{{ Link.sort('modified')}}</div>
                 <div></div>
             </nav>

diff --git a/src/View/Helper/LinkHelper.php b/src/View/Helper/LinkHelper.php
@@ -17,6 +17,7 @@
 use Cake\Filesystem\Folder;
 use Cake\Routing\Router;
 use Cake\Utility\Hash;
+use Cake\Utility\Inflector;
 use Cake\View\Helper;
 
 /**
@@ -91,7 +92,7 @@ public function sort($field): void
             }
         }
         $url = $this->replaceParamUrl('sort', $sortValue);
-        echo '<a href="' . $url . '" class="' . $class . '">' . __($field) . '</a>';
+        echo '<a href="' . $url . '" class="' . $class . '">' . Inflector::humanize($field) . '</a>';
     }
 
     /**