Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: Enable mounting of existing cm #147

Merged
merged 4 commits into from
Jan 6, 2025
Merged

[common]: Enable mounting of existing cm #147

merged 4 commits into from
Jan 6, 2025

Conversation

wthhub
Copy link
Contributor

@wthhub wthhub commented Jan 6, 2025 •
edited
Loading

What this PR does:

This changes allows mounting existing configmaps as volumes.

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@wthhub wthhub requested a review from a team as a code owner January 6, 2025 10:00
@wthhub wthhub requested a review from fanks4 January 6, 2025 10:00
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2025
wthhub added 4 commits January 6, 2025 15:11
@wthhub
[common]: enable mounting of existing cm
dd9219f 
Signed-off-by: Thomas Wessner <thomas.wessner@bedag.ch>
@wthhub
[common]: enable mounting of existing cm
9458129 
Signed-off-by: Thomas Wessner <thomas.wessner@bedag.ch>
@wthhub
[common]: update version number and enable the feature when items is set
07e8e4a 
Signed-off-by: Thomas Wessner <thomas.wessner@bedag.ch>
@wthhub
[common]: update version number and enable the feature when items is set
b58864c 
Signed-off-by: Thomas Wessner <thomas.wessner@bedag.ch>
@wthhub wthhub force-pushed the feat/common-enable-mounting-of-existing-cm branch from 41937e6 to b58864c Compare January 6, 2025 14:12
fanks4
fanks4 approved these changes Jan 6, 2025
View reviewed changes
Copy link

@fanks4 fanks4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your merge request @wthhub.
Since it only adds items it can not break existing releases.
Please consider that key and path are optional values and may stay empty when not defined in values.yaml.

@wthhub wthhub merged commit edfcf47 into master Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanks4 fanks4 fanks4 approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wthhub @fanks4