Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: appVersion available as optional value #146

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[common]: appVersion available as optional value #146

merged 2 commits into from
Jan 6, 2025

Conversation

gnaex
Copy link
Contributor

@gnaex gnaex commented Dec 19, 2024

What this PR does:

Adds optional value "appVersion" to override "Chart.AppVersion" in label "app.kubernetes.io/version"

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

gnaex and others added 2 commits December 19, 2024 13:06
@gnaex gnaex requested a review from a team as a code owner December 19, 2024 15:39
@gnaex gnaex requested a review from adberger December 19, 2024 15:39
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2024
@gnaex gnaex changed the title feat(common): appVersion available as optional value [common]: appVersion available as optional value Dec 19, 2024
@ln-ro ln-ro requested review from wthhub and fanks4 and removed request for adberger December 19, 2024 19:36
@wthhub
Copy link
Contributor

wthhub commented Dec 20, 2024

Thank you @gnaex,
the adjustments look good, but it looks like one commit is not yet correctly verified. Can you please correct this?

@gnaex
Copy link
Contributor Author

gnaex commented Dec 20, 2024

Thank you @gnaex, the adjustments look good, but it looks like one commit is not yet correctly verified. Can you please correct this?

Thank you

Thank you @gnaex, the adjustments look good, but it looks like one commit is not yet correctly verified. Can you please correct this?

Thank you @wthhub it should be signed now.

fanks4
fanks4 approved these changes Jan 6, 2025
View reviewed changes
Copy link

@fanks4 fanks4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the merge request @gnaex.
I can totally agree with your proposed changes.

@wthhub wthhub merged commit 68c1c42 into bedag:master Jan 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wthhub wthhub wthhub approved these changes

@fanks4 fanks4 fanks4 approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnaex @wthhub @fanks4