Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcluster]: Allow installation of online manifests, disable autoscaler as default, remove unused values & fix references #141

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

adberger
Copy link
Contributor

What this PR does:

  • Disable autoscaler
  • Fix reference of .controlPlane.endpoint
  • Fix indentation in charts/vcluster/templates/extra-manifests.yaml
  • Add extraOnlineManifests & extraOnlineManifestsOnInstall for vclusters

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
…caler as default

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@adberger adberger requested a review from a team as a code owner December 16, 2024 07:02
@adberger adberger requested a review from patrick-men December 16, 2024 07:02
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2024
Copy link

@patrick-men patrick-men left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adberger adberger merged commit 816e799 into bedag:master Dec 16, 2024
4 of 5 checks passed
@adberger adberger changed the title [vcluster]: llow installation of online manifests, disable autoscaler as default, remove unused values & fix references [vcluster]: Allow installation of online manifests, disable autoscaler as default, remove unused values & fix references Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants