Plugin for schema validation #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwiniK-protean
requested review from
tanyamadaan,
ashishkgGoogle and
poojajoshi2
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
tanyamadaan
reviewed
Mar 3, 2025
…ugin, and deleted schema_die path from config
tanyamadaan
requested changes
Mar 6, 2025
| parts := strings.Split(relativePath, string(os.PathSeparator)) | ||
|
|
||
| // Ensure that the file path has at least 3 parts: domain, version, and schema file. | ||
| if len(parts) < 3 { |
There was a problem hiding this comment.
Add more robust validation to handle edge cases, such as empty paths or incorrect directory structures.
| start := time.Now() | ||
|
|
||
| var memStatsBefore runtime.MemStats | ||
| runtime.ReadMemStats(&memStatsBefore) |
There was a problem hiding this comment.
Consider moving this to a debug mode or removing it entirely, not needed in production.
There was a problem hiding this comment.
Please review all your test cases, add descriptions, make sure it is clear on what is expected outcome.
There was a problem hiding this comment.
Test case for payloads with missing or extra fields?
| // indexed by their schema filenames. | ||
| func (vp *TekuriValidatorProvider) Initialize(schemaDir string) (map[string]plugins.Validator, error) { | ||
| // Initialize the SchemaCache map to store the compiled schemas using a unique key (domain/version/schema). | ||
| vp.SchemaCache = make(map[string]*jsonschema.Schema) |
There was a problem hiding this comment.
Initialize the SchemaCache in the constructor or ensure it is only initialized once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a plugin that validates a payload against a predefined schema to ensure data integrity. Additionally, I developed a small API that handles POST requests, utilizing this plugin to validate the incoming data before processing it further.