chore: Create toggle with submenu in "CreateToggleForSelection" #1437
+148
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tliks
commented
Feb 4, 2025
Comment on lines
+51
to
+76
| // Try to find target submenu that should be the parent of toggles | ||
| ModularAvatarMenuItem targetSubMenu = null; | ||
| if (TryGetChildrenSourceSubmenu(parent, out var subMenu)) | ||
| { | ||
| // If parent has subMenu, use it as target submenu. | ||
| targetSubMenu = subMenu; | ||
| } | ||
| else | ||
| { | ||
| // If parent hasn't subMenu, get submenus at the same level | ||
| var subMenus = new List<ModularAvatarMenuItem>(); | ||
| foreach (Transform sibling in parent.transform) | ||
| { | ||
| if (TryGetChildrenSourceSubmenu(sibling.gameObject, out var m)) { subMenus.Add(m); } | ||
| } | ||
| // Filter to submenus with the same name | ||
| subMenus = subMenus.Where(m => m.gameObject.name == subMenuName).ToList(); | ||
| // If only one submenu as target is found, use it as target submenu. | ||
| if (subMenus.Count() == 1) targetSubMenu = subMenus.First(); | ||
| } | ||
|
|
||
| if (targetSubMenu != null) // If target SubMenu is found, add the toggles as children of it. | ||
| { | ||
| parent = targetSubMenu.gameObject; | ||
| CreateToggleImpl(targets, parent, s => s.name, forSelection, createInstaller:false); | ||
| } |
There was a problem hiding this comment.
複数選択の度にサブメニューが増えるのも微妙だと思ったので、既存のサブメニューを探し、見つかった場合はその子としてトグルのみ生成するようにしました。
これがあった方が基本的に便利だと思うので入れましたが、少なくとも現在の方法では適切でないサブメニューへとトグルが生成される可能性も一応あるので、入れるべきかどうかはお任せします
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1436
複数選択時などにSub MenuのMenu Itemを生成し、その子としてToggleを生成するように変更します。