Fixes error when merging same parameter with different type in RC menu item #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunderscore
requested changes
Oct 22, 2024
Editor/ReactiveObjects/AnimationGeneration/ReactiveObjectPass.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the fix! |
bdunderscore
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fixes #1299
The issue causing type mismatch is it doesn't do type checking when generating new states, and re-using existing AnimatorCombiner class might be just good enough here.
(P.S. This is a quick fix as this issue also affects Hatch Menu, one of my gimmick with an installer that uses Modular Avatar)