opti: prune garbage sample expression parameters found in VRChat's te…

…mplate asset
bdunderscore · Dec 26, 2023 · 787b515 · 787b515
1 parent aa69856
commit 787b515
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/Editor/OptimizationPasses/PruneParametersPass.cs b/Editor/OptimizationPasses/PruneParametersPass.cs
@@ -0,0 +1,17 @@
+using System.Linq;
+using nadena.dev.ndmf;
+
+namespace nadena.dev.modular_avatar.core.editor
+{
+    internal class PruneParametersPass : Pass<PruneParametersPass>
+    {
+        protected override void Execute(ndmf.BuildContext context)
+        {
+            var expParams = context.AvatarDescriptor.expressionParameters;
+            if (expParams != null && context.IsTemporaryAsset(expParams))
+            {
+                expParams.parameters = expParams.parameters.Where(p => !string.IsNullOrEmpty(p.name)).ToArray();
+            }
+        }
+    }
+}
diff --git a/Editor/OptimizationPasses/PruneParametersPass.cs.meta b/Editor/OptimizationPasses/PruneParametersPass.cs.meta
diff --git a/Editor/PluginDefinition/PluginDefinition.cs b/Editor/PluginDefinition/PluginDefinition.cs
@@ -30,7 +30,7 @@ protected override void Configure()
             seq.Run("Clone animators", AnimationUtil.CloneAllControllers);
 
             seq = InPhase(BuildPhase.Transforming);
-            seq.Run("Validate configuration", 
+            seq.Run("Validate configuration",
                 context => ComponentValidation.ValidateAll(context.AvatarRootObject));
             seq.WithRequiredExtension(typeof(ModularAvatarContext), _s1 =>
             {
@@ -83,6 +83,7 @@ protected override void Configure()
                         UnityEngine.Object.DestroyImmediate(component);
                     }
                 });
+                seq.Run(PruneParametersPass.Instance);
             });
 
             InPhase(BuildPhase.Optimizing)