Perform hit detection in physical LED space #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously hit detection was done in virtual LED space (i.e. 0-1000) but this caused some weirdness, especially with a small number of LED. For example you could end up in a situation where visually the edge of an attack totally hits an enemy, but the enemy does not die...because in virtual space the attack didn't quite reach the enemy even though they are aliased to the same LED on the strip. This was confusing. Now all hit detection is done in the actual LED space, so what you see is what you get.
|
@rschenk Thanks. That sounds like a good idea. I will not be able to test the code for about 10 days. I am out of town without a TWANG. I'll merge it as soon as I can and push it on the TWANG32 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously hit detection was done in virtual LED space (i.e. 0-1000) but this caused some weirdness, especially with a small number of LED. For example you could end up in a situation where visually the edge of an attack totally hits an enemy, but the enemy does not die...because in virtual space the attack didn't quite reach the enemy even though they are aliased to the same LED on the strip. This was confusing. Now all hit detection is done in the actual LED space, so what you see is what you get.