Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexer Integration #5

Merged
merged 54 commits into from
Jun 25, 2024
Merged

Indexer Integration #5

merged 54 commits into from
Jun 25, 2024

Conversation

ankurdubey521
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@ankurdubey521 ankurdubey521 marked this pull request as ready for review June 25, 2024 12:01
}

#[cfg(test)]
mod tests {
pub mod tests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pub here

Comment on lines +21 to +23
/// Run the Solver (default)
#[arg(short, long)]
solver: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can se the default here instead

@AmanRaj1608 AmanRaj1608 merged commit d6c93a6 into dev Jun 25, 2024
1 check failed
@AmanRaj1608 AmanRaj1608 deleted the feat/routing-indexer branch June 25, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants