Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFRS - Upgrade react-table to v7 #2049

Open
AlexZorkin opened this issue Jan 25, 2023 · 0 comments
Open

TFRS - Upgrade react-table to v7 #2049

AlexZorkin opened this issue Jan 25, 2023 · 0 comments
Labels
Low Low priority Tech Debt

Comments

@AlexZorkin
Copy link
Collaborator

Description:

In order to upgrade React to v18, we have to first upgrade react-table to version 7.

Acceptance Criteria:

Given I am a user, when I navigate to pages using react-table, then I should not notice any new behaviour and things should look the same as well.

Development Checklist:

(1) V7 of react-table has no out-of-the-box component for you to use; you must create your own using their new hooks-based api and use that. A guide can be found here: https://levelup.gitconnected.com/migrating-react-table-from-v6-to-v7-dc840eb7ad7.

Also see the official docs: https://react-table-v7.tanstack.com/docs/overview

(2) In StateSavingReactTable.js, we extend the v6 ReactTable component; this is no longer possible with v7. This may not be a bad thing; I think any customizations we want to do may be easier now with v7.

(3) There are > 20 instances of across the application; these will all have to be replaced and tested.

Notes:

(1) No out-of-the-box styling with v7 either; we can copy the styles from v6 and use that.

@AlexZorkin AlexZorkin added Low Low priority Task Any work that does not directly impact the user labels Jan 25, 2023
@justin-lepitzki justin-lepitzki added Tech Debt and removed Task Any work that does not directly impact the user labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Low priority Tech Debt
Projects
None yet
Development

No branches or pull requests

2 participants