UI - upgrade node to 20

.github/workflows/search-ui-cd.yml

@@ -13,18 +13,18 @@ on:
         required: true
         type: choice
         options:
-        - dev
-        - test
-        - sandbox
-        - prod
+          - dev
+          - test
+          - sandbox
+          - prod
       tagname:
         description: "Specify a previous version (git tag) to deploy"
         required: false
         default: ""
 
 jobs:
   search-ui-cd:
-    uses: bcgov/bcregistry-sre/.github/workflows/ui-cd.yaml@main
+    uses: bcgov/bcregistry-sre/.github/workflows/ui-cd-node20.yaml@main
     with:
       environment: ${{ inputs.environment }}
       tagname: ${{ inputs.tagname }}

.github/workflows/search-ui-ci.yml

@@ -6,7 +6,6 @@ on:
     paths:
       - "search-ui/**"
 
-
 defaults:
   run:
     shell: bash
@@ -19,7 +18,7 @@ jobs:
     if: github.repository == 'bcgov/registries-search'
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: "true"
 
   linting:
@@ -28,55 +27,59 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.14.2]
+        node-version: [20]
 
     steps:
-      - uses: actions/checkout@v3
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - name: Setup node
+        uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ matrix.node }}
+
       - name: Install dependencies
-        run: |
-          make setup
-      - name: Linting
-        run: |
-          make lint
+        run: npm install
+
+      - name: Lint
+        run: npm run lint
 
-  testing-coverage:
+  unit-testing:
     needs: setup-job
     runs-on: ubuntu-20.04
 
     strategy:
       matrix:
-        node-version: [16.14.2]
+        node-version: [20]
 
     steps:
-      - uses: actions/checkout@v3
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - name: Setup node
+        uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ matrix.node }}
+
       - name: Install dependencies
-        run: |
-          make setup
-      - name: Test with Jest
-        id: test
-        run: |
-          make test
-      # - name: Upload coverage to Codecov
-      #   uses: codecov/codecov-action@v3
-      #   with:
-      #     name: codecov-search-ui
-      #     fail_ci_if_error: true
+        run: npm install
+
+      - name: Test
+        run: npm run test:unit
 
   build-check:
     needs: setup-job
     runs-on: ubuntu-20.04
 
+    strategy:
+      matrix:
+        node-version: [20]
+
     steps:
-      - uses: actions/checkout@v3
-      - name: build to check strictness
-        id: build
-        run: |
-          make build-nc
+      - uses: actions/checkout@v4
+      - name: Setup node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Build
+        run: npm run build

search-ui/.eslintrc.js

@@ -20,7 +20,7 @@ module.exports = {
       'warn',
       { code: 120, ignoreRegExpLiterals: true, ignoreTrailingComments: true },
     ],
-    'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
+    "no-console": ["error", { "allow": ["warn", "error", "info"] }],
     'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     // 'prettier/prettier': [