You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before #346 was implemented, the cronjob that moves active passes to expired at midnight was running AFTER the metrics for the same day were updated for the last time, making the metrics object appear to show that these passes never expired. To force the metrics object to show the correct status, the API now expires all active passes at 6pm instead of midnight.
There is still a small issue where users can book same-day passes after 6pm. If they book close enough to midnight, these passes still show up incorrectly in the metrics object. We need to prevent users from booking passes after the facility closes - these bookings are not valid anyways.
Notes:
We should determine what the closing hour is - whether it is 6pm across all parks/facilities or whether it needs to be facility specifc - the latter is far more complex.
There may be a UX/Design portion to this: how do we convey to the public users that they cannot book a pass after 6pm? Grey out options, informative text, etc.
This ticket stems from #346.
Before #346 was implemented, the cronjob that moves
active
passes toexpired
at midnight was running AFTER the metrics for the same day were updated for the last time, making the metrics object appear to show that these passes never expired. To force the metrics object to show the correct status, the API now expires all active passes at 6pm instead of midnight.There is still a small issue where users can book same-day passes after 6pm. If they book close enough to midnight, these passes still show up incorrectly in the metrics object. We need to prevent users from booking passes after the facility closes - these bookings are not valid anyways.
Notes:
Refer to #346 for more information.
AC:
The text was updated successfully, but these errors were encountered: