Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUP - establish facility closing time and prevent users from booking same-day passes beyond this time. #349

Open
2 tasks
cameronpettit opened this issue Feb 22, 2024 · 0 comments
Assignees
Labels

Comments

@cameronpettit
Copy link
Contributor

This ticket stems from #346.

Before #346 was implemented, the cronjob that moves active passes to expired at midnight was running AFTER the metrics for the same day were updated for the last time, making the metrics object appear to show that these passes never expired. To force the metrics object to show the correct status, the API now expires all active passes at 6pm instead of midnight.

There is still a small issue where users can book same-day passes after 6pm. If they book close enough to midnight, these passes still show up incorrectly in the metrics object. We need to prevent users from booking passes after the facility closes - these bookings are not valid anyways.

Notes:

  • We should determine what the closing hour is - whether it is 6pm across all parks/facilities or whether it needs to be facility specifc - the latter is far more complex.
  • There may be a UX/Design portion to this: how do we convey to the public users that they cannot book a pass after 6pm? Grey out options, informative text, etc.

Refer to #346 for more information.

AC:

  • API prevents same-day bookings after closing hour.
  • Public front end informs/prevents public users from booking after closing hour in a user friendly manner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants