Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S] Revoke and replace API keys for bc-parks-reservations and bc-parks-reservations-test #295

Open
JLWade opened this issue Sep 19, 2023 · 4 comments
Assignees
Labels
DUP good first issue Good for newcomers

Comments

@JLWade
Copy link

JLWade commented Sep 19, 2023

Please see email from GC notify for more info (Jess, Mark, and Cam have a copy). Instructions below from email (api keys within email):

  • sign in to GC Notify
  • Create new API keys
  • Update application code to use new API keys
  • Test application
  • Revoke old API keys

This needs to be done for test and live GC Notify services.

Acceptance Criteria

  • bc-parks-reservations-test is using new api keys and old ones are revoked
  • bc-parks-reservations is using new api keys and old ones are revoked

QA / Testing:

  • verify that emails are sending as expected via GC notify

Notes:

  • As a security precaution, we now add a prefix to API keys. The prefix helps safeguard your information and recipients’ privacy.
  • needs to happen before Nov 18, 2023
@JLWade JLWade added the DUP label Sep 19, 2023
@ashley-dhillon ashley-dhillon changed the title Revoke and replace API keys for bc-parks-reservations and bc-parks-reservations-test [S] Revoke and replace API keys for bc-parks-reservations and bc-parks-reservations-test Sep 19, 2023
@JLWade JLWade added the good first issue Good for newcomers label Oct 17, 2023
@Christopher-walsh22
Copy link
Contributor

Updated the key used in DEV/TEST in AWS and Revoked the old API keys. Submitting for testing once confirmed everything is proper in these environments will replicate in PROD

@manuji
Copy link

manuji commented Oct 19, 2023

Tested on TEST: Passed

  • Verified the following emails are working on the TEST environment after the update. Please proceed with updating the PROD environment. @Christopher-walsh22 FYI @JLWade

[x] Pass booking confirmation for DUP parking pass with QR code
[x] Pass booking confirmation for DUP Trail pass with QR code
[x] Pass booking confirmation for DUP parking pass without QR code
[x] Pass booking confirmation for DUP Trail pass without QR code
[x] Cancellation emails
[ ] Survey email - Not applicable to the Summer passes.
[x] Reminder email

@manuji
Copy link

manuji commented Oct 23, 2023

This change cannot be tested on PROD as we have shutdown passes for all PROD facilities. Sending this to PO review and looking forward to suggestions. @JLWade

@manuji manuji assigned JLWade and unassigned Christopher-walsh22 Oct 23, 2023
@manuji manuji moved this from QA to PO Review in BC Parks Digital Delivery (Team Osprey) Oct 23, 2023
@JLWade
Copy link
Author

JLWade commented Oct 23, 2023

I'll move this to done and updates can be done in PROD (if not complete already) - @manuji @Christopher-walsh22
Is there a way to book a pass at one of the prod parks in the backend without opening it?

@JLWade JLWade moved this from PO Review to Done in BC Parks Digital Delivery (Team Osprey) Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DUP good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants