Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: append more context to errors from the consumer #559

Merged
merged 4 commits into from
Jan 28, 2025
Merged

feat: append more context to errors from the consumer #559

merged 4 commits into from
Jan 28, 2025

Conversation

nicholasgriffintn
Copy link
Member

@nicholasgriffintn nicholasgriffintn commented Jan 28, 2025 •
edited
Loading

This appends messageIds to the errors that are thrown by standard and timeout errors, this should make it easier to debug these errors.

This also appends the queueUrl to sqsErrors, alongside the messages if available.

@nicholasgriffintn nicholasgriffintn requested review from a team as code owners January 28, 2025 20:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

LCOV of commit a7f1395 during Comment PR Coverage #97

Summary coverage rate:
  lines......: 97.1% (945 of 973 lines)
  functions..: 100.0% (35 of 35 functions)
  branches...: no data found

Files changed coverage rate:
                   |Lines       |Functions  |Branches    
  Filename         |Rate     Num|Rate    Num|Rate     Num
  =======================================================
  src/consumer.ts  | 3.2%    647| 0.0%    21|    -      0
  src/errors.ts    | 4.8%    165| 0.0%     8|    -      0

@nicholasgriffintn nicholasgriffintn changed the title feat: append messageIds to standard and timeout errors feat: append more context to errors from the consumer Jan 28, 2025
@nicholasgriffintn nicholasgriffintn merged commit 7bc55fc into canary Jan 28, 2025
13 checks passed
@nicholasgriffintn nicholasgriffintn deleted the message-ids branch January 28, 2025 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicholasgriffintn