Skip to content

ruby_bundle should support Gemfiles with gemspec method #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kigster opened this issue Nov 23, 2019 · 1 comment
Open

ruby_bundle should support Gemfiles with gemspec method #11

kigster opened this issue Nov 23, 2019 · 1 comment
Assignees
@kigster
Labels
feature New feature or request rule::ruby_bundle
Milestone
M-0.2

Comments

@kigster
Copy link
Contributor

kigster commented Nov 23, 2019 •
edited
Loading

Currently bundle is created based on the Gemfile and Gemfile.lock only.

However, many custom gems use gemspec inside the Gemfile to delegate gem listing to the *.gemspec file.

bundle install works just the same, except it needs to have the gem's gemspec file present and at the same level as the Gemfile.
@kigster kigster changed the title Allow bundle install to select specific gems from a shared GemFile (rather than all) Allow bundle install to use Gemfile that references a gemspec for the gem sources. Dec 2, 2019
@kigster kigster assigned kigster and unassigned grahamjenson Dec 2, 2019
@kigster kigster assigned grahamjenson and unassigned kigster Dec 2, 2019
@kigster kigster closed this as completed Dec 2, 2019
@kigster kigster changed the title Allow bundle install to use Gemfile that references a gemspec for the gem sources. Support "gemspec" method in the Gemfiles during bundle_install Dec 2, 2019
@kigster kigster assigned kigster and unassigned grahamjenson Dec 2, 2019
@kigster kigster added this to the M-0.2 milestone Dec 2, 2019
@kigster kigster reopened this Dec 2, 2019
kigster pushed a commit to kigster/rules_ruby that referenced this issue Feb 29, 2020
@ClareCat @kigster
Add force_gem_pristine attr to rb_binary (bazelruby#11)
ad2850b 
* Add gem pristine functionality to unblock gems

* Run buildifier, move ruby attrs
@kigster
Copy link
Contributor Author

kigster commented Feb 29, 2020

We still need this, but I am gonna ponder on this for now.

@kigster kigster changed the title Support "gemspec" method in the Gemfiles during bundle_install ruby_bundle should support Gemfiles with gemspec method Feb 29, 2020
@kigster kigster added the feature New feature or request label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kigster kigster

Labels
feature New feature or request rule::ruby_bundle
Projects
None yet
Milestone
M-0.2
Development

No branches or pull requests
2 participants
@kigster @grahamjenson