Skip to content

Commit

Permalink
fix(toolchains): include tcl/** files in Windows interpreter (#1552)
Browse files Browse the repository at this point in the history
closes #1544 

The tcl subdirectory of the interpreter Windows build needs to be kept
otherwise packages such as matplotlib will break.

Co-authored-by: Richard Levasseur <rlevasseur@google.com>
  • Loading branch information
th0masb and rickeylev authored Nov 16, 2023
1 parent 2c82656 commit 679ba7c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ Breaking changes:
* (gazelle) Generate a single `py_test` target when `gazelle:python_generation_mode project`
is used.

* (toolchains) Keep tcl subdirectory in Windows build of hermetic interpreter.

* (bzlmod) sub-modules now don't have the `//conditions:default` clause in the
hub repos created by `pip.parse`. This should fix confusing error messages
in case there is a misconfiguration of toolchains or a bug in `rules_python`.
Expand Down
1 change: 1 addition & 0 deletions python/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ def _python_repository_impl(rctx):
"libs/**",
"Scripts/**",
"share/**",
"tcl/**",
]
else:
glob_include += [
Expand Down

0 comments on commit 679ba7c

Please sign in to comment.