[8.1.0] Forward exec_properties to main test spawn's execution info
#25138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `exec_properties` such as `no-remote-exec` effective for the main test spawn, where they previously only affected post-processing spawns such as test XML generation. Pros: * relatively simple (and more precise than `tags`) way to affect test execution using existing API * provides consistency between test spawns * provides consistency between test spawns and spawns produced by Starlark actions Cons: * similar to Starlark actions, execution info is "polluted" with `exec_properties` such as `OSFamily` and `container-image`, which shows up in `aquery` and may increase memory usage * the fact that `exec_properties` end up in execution info appears to have been an unintentional side effect of bazelbuild@adb56cc rather than a conscious design decision * provides functionality may be better addressed by [Execution Platform Scoped Spawn Strategies](https://github.com/bazelbuild/proposals/blob/main/designs/2023-06-04-exec-platform-scoped-spawn-strategies.md) Closes bazelbuild#24979. PiperOrigin-RevId: 721088264 Change-Id: I7ce5c899ed6a647831f156f6b34c1f776655425c
bazel-io
added
team-Configurability
bazel-io
added
the
awaiting-review
katre
approved these changes
Jan 29, 2025
Merged
via the queue into
bazelbuild:release-8.1.0
with commit Jan 29, 2025
ad2d568
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
exec_propertiessuch asno-remote-execeffective for the main test spawn, where they previously only affected post-processing spawns such as test XML generation.Pros:
tags) way to affect test execution using existing APICons:
exec_propertiessuch asOSFamilyandcontainer-image, which shows up inaqueryand may increase memory usageexec_propertiesend up in execution info appears to have been an unintentional side effect of adb56cc rather than a conscious design decisionCloses #24979.
PiperOrigin-RevId: 721088264
Change-Id: I7ce5c899ed6a647831f156f6b34c1f776655425c
Commit 357b091