Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_match_error attribute to toolchain_type #25134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 29, 2025

Fixes #12318

RELNOTES: The new no_match_error attribute on toolchain_type can be used to show a custom message when no matching toolchain is found for that type, but one is required.

@fmeum fmeum requested review from a team and lberki as code owners January 29, 2025 19:31
@fmeum fmeum requested review from katre and removed request for a team and lberki January 29, 2025 19:31
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Jan 29, 2025
RELNOTES: The new `no_match_error` attribute on `toolchain_type` can be used to show a custom message when no matching toolchain is found for that type, but one is required.
@fmeum fmeum force-pushed the 12318-toolchain-error-message branch from d059e07 to b60a0f4 Compare January 29, 2025 19:49
@katre katre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 29, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 29, 2025

@bazel-io fork 8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow toolchain types to customize the error for missing toolchains
3 participants