Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See and use more than 64 CPUs on Windows #25087

Closed
wants to merge 2 commits into from
Closed

See and use more than 64 CPUs on Windows #25087

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 27, 2025

Fixes #24827

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 27, 2025

@bazel-io fork 8.1.0

@fmeum fmeum requested a review from meteorcloudy January 27, 2025 15:12
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 27, 2025
@bazel-io bazel-io mentioned this pull request Jan 27, 2025
Closed
@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 27, 2025
@sgowroji
Copy link
Member

Hi @fmeum, Could you please take a look at the failing checks?

@fmeum fmeum force-pushed the 24827-windows-cpus branch from 90e5258 to 8216905 Compare January 28, 2025 10:57
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 28, 2025

@sgowroji Fixed

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Jan 28, 2025
@fmeum fmeum force-pushed the 24827-windows-cpus branch from cca52be to 1449cff Compare January 28, 2025 11:17
meteorcloudy
meteorcloudy approved these changes Jan 28, 2025
View reviewed changes
src/main/cpp/blaze.cc Show resolved Hide resolved
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 28, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 30, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 30, 2025
@fmeum @bazel-io
See and use more than 64 CPUs on Windows
e6ac145 
Fixes bazelbuild#24827

Closes bazelbuild#25087.

PiperOrigin-RevId: 721285704
Change-Id: Id5c1a8b699f7c5bca1995dba7a8c871805b1a598
@bazel-io bazel-io mentioned this pull request Jan 30, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2025
@bazel-io @fmeum
[8.1.0] See and use more than 64 CPUs on Windows (#25140)
12a3fc0 
Fixes #24827

Closes #25087.

PiperOrigin-RevId: 721285704
Change-Id: Id5c1a8b699f7c5bca1995dba7a8c871805b1a598

Commit
f64f360

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum deleted the 24827-windows-cpus branch January 31, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel does not use all cores on Windows Server Multi-Socket machine
3 participants
@fmeum @sgowroji @meteorcloudy