Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1.0] Update Bazel's embedded JDK to 23.0.1 #25014

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 22, 2025

In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows --watchfs to handle a configurable number of changes to a watched path rather than maxing out at 500.

Windows arm64 can switch to Zulu JDK 21.

Since async-profiler is released very rarely (last release in January) and the latest release is not compatible with JDK 23, this PR consumes a recent nightly release instead. This has the side effect of removing a bit of bloat from the server jar as it no longer contains async profiler's native library for all OSes/arches.

Closes #24609.

PiperOrigin-RevId: 707717223
Change-Id: I29fe86eca1e0deeae813e7dbbf7d60859e3cba5e

(cherry picked from commit e586a5e)

Fixes #24695

In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

Windows arm64 can switch to Zulu JDK 21.

Since async-profiler is released very rarely (last release in January) and the latest release is not compatible with JDK 23, this PR consumes a recent nightly release instead. This has the side effect of removing a bit of bloat from the server jar as it no longer contains async profiler's native library for all OSes/arches.

Closes bazelbuild#24609.

PiperOrigin-RevId: 707717223
Change-Id: I29fe86eca1e0deeae813e7dbbf7d60859e3cba5e

(cherry picked from commit e586a5e)
@fmeum fmeum requested a review from a team as a code owner January 22, 2025 07:57
@fmeum fmeum requested a review from meteorcloudy January 22, 2025 07:57
@github-actions github-actions bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Jan 22, 2025
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Jan 22, 2025
@meteorcloudy meteorcloudy added this pull request to the merge queue Jan 22, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2025
In addition to performance improvements, this JDK release contains a fix
for https://bugs.openjdk.org/browse/JDK-8330077, which allows
`--watchfs` to handle a configurable number of changes to a watched path
rather than maxing out at 500.

Windows arm64 can switch to Zulu JDK 21.

Since async-profiler is released very rarely (last release in January)
and the latest release is not compatible with JDK 23, this PR consumes a
recent nightly release instead. This has the side effect of removing a
bit of bloat from the server jar as it no longer contains async
profiler's native library for all OSes/arches.

Closes #24609.

PiperOrigin-RevId: 707717223
Change-Id: I29fe86eca1e0deeae813e7dbbf7d60859e3cba5e

(cherry picked from commit e586a5e)

Fixes #24695
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@iancha1992 iancha1992 changed the title Update Bazel's embedded JDK to 23.0.1 [8.1.0] Update Bazel's embedded JDK to 23.0.1 Jan 22, 2025
@iancha1992 iancha1992 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into bazelbuild:release-8.1.0 with commit b6a9c84 Jan 22, 2025
46 checks passed
@fmeum fmeum deleted the 24695-8.1.0 branch January 24, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants