[8.1.0] Reduce retention and early materialization of VirtualActionInput
#25008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazelbuild@b82dcdc introduced a way for parameter files to be materialized lazily and in a streaming fashion. For this to be effective, the contents of `VirtualActionInput`s should not be retained and, ideally, never or only briefly materialized in full. This is achieved by replacing the digest computations with a streaming approach and avoiding retention of `VirtualActionInput` in `MerkleTree`s, which may be cached. All cache protocols are streamlined to accept a `Blob`, which is a closeable supplier of `InputStream`s that is automatically closed after the upload has completed (which may require retries). Along the way, file nodes in `MerkleTree`s are stored unwrapped to reduce memory usage. Closes bazelbuild#24891. PiperOrigin-RevId: 718042524 Change-Id: I1567cf6ca36cbf5e1146c91df34157c9192bb822
iancha1992
added
team-Performance
tjgq
approved these changes
Jan 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
…nput` (#25008) b82dcdc introduced a way for parameter files to be materialized lazily and in a streaming fashion. For this to be effective, the contents of `VirtualActionInput`s should not be retained and, ideally, never or only briefly materialized in full. This is achieved by replacing the digest computations with a streaming approach and avoiding retention of `VirtualActionInput` in `MerkleTree`s, which may be cached. All cache protocols are streamlined to accept a `Blob`, which is a closeable supplier of `InputStream`s that is automatically closed after the upload has completed (which may require retries). Along the way, file nodes in `MerkleTree`s are stored unwrapped to reduce memory usage. Closes #24891. PiperOrigin-RevId: 718042524 Change-Id: I1567cf6ca36cbf5e1146c91df34157c9192bb822 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
bazelbuild:release-8.1.0
with commit Jan 24, 2025
16f6d5a
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b82dcdc introduced a way for parameter files to be materialized lazily and in a streaming fashion. For this to be effective, the contents of
VirtualActionInputs should not be retained and, ideally, never or only briefly materialized in full.This is achieved by replacing the digest computations with a streaming approach and avoiding retention of
VirtualActionInputinMerkleTrees, which may be cached. All cache protocols are streamlined to accept aBlob, which is a closeable supplier ofInputStreams that is automatically closed after the upload has completed (which may require retries).Along the way, file nodes in
MerkleTrees are stored unwrapped to reduce memory usage.Closes #24891.
PiperOrigin-RevId: 718042524
Change-Id: I1567cf6ca36cbf5e1146c91df34157c9192bb822