Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution info to --subcommands output #24982

Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 20, 2025

Makes it easier to debug where spawns (of which there may be multiple per action) are actually executed (remote vs local, with caching, ...).

Work towards #23802

Makes it easier to debug where spawns (of which there may be multiple per action) are actually executed (remote vs local, with caching, ...).
@fmeum fmeum requested a review from katre January 20, 2025 09:48
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 20, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 20, 2025

@katre This is missing some info for test spawns. I wonder what the difference between Spawn#getExecutionInfo() and Spawn#getCombinedExecutionProperties() is, do you happen to know?

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 20, 2025

@katre Could you also provide context on e4c1c43? It looks like execution info and execution properties still exist as distinct concepts. Is this necessary?

@fmeum fmeum marked this pull request as draft January 20, 2025 10:44
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 20, 2025

The distinction between the three is too confusing to have this printed out for now. I would still be interested in answers to the questions above if you have them.

@fmeum fmeum closed this Jan 20, 2025
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 20, 2025
@katre
Copy link
Member

katre commented Jan 21, 2025

Ideally we'd unify execution requirements, properties, and info. Unfortunately there's a lot of legacy cruft in there (and even more so in the internal blaze codebase) that makes it too large to be worth taking on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants