-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --file_write_strategy
to Bazel
#24921
Open
fmeum
wants to merge
18
commits into
bazelbuild:master
Choose a base branch
from
fmeum:24808-file-write
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
24808-file-write
branch
4 times, most recently
from
January 15, 2025 05:23
afdfcd4
to
b9c24bd
Compare
# Conflicts: # src/main/java/com/google/devtools/build/lib/actions/FileArtifactValue.java # src/main/java/com/google/devtools/build/lib/remote/AbstractActionInputPrefetcher.java # src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
� Conflicts: � src/main/java/com/google/devtools/build/lib/actions/cache/VirtualActionInput.java � src/main/java/com/google/devtools/build/lib/remote/merkletree/DirectoryTree.java � src/main/java/com/google/devtools/build/lib/remote/merkletree/MerkleTree.java
# Conflicts: # src/test/java/com/google/devtools/build/lib/actions/ActionCacheCheckerTest.java # src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java
fmeum
force-pushed
the
24808-file-write
branch
2 times, most recently
from
January 27, 2025 13:18
2f96a9b
to
323be9b
Compare
fmeum
force-pushed
the
24808-file-write
branch
from
January 27, 2025 13:58
323be9b
to
64cb781
Compare
fmeum
changed the title
Lazily write files with BwoB
Add Jan 28, 2025
--file_write_strategy
to Bazel
fmeum
force-pushed
the
24808-file-write
branch
from
January 29, 2025 13:29
5379621
to
e1dc9ba
Compare
fmeum
force-pushed
the
24808-file-write
branch
from
January 31, 2025 16:46
07e7ee4
to
7bb7210
Compare
github-actions
bot
added
team-Performance
Issues for Performance teams
team-Configurability
platforms, toolchains, cquery, select(), config transitions
team-Remote-Exec
Issues and PRs for the Execution (Remote) team
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Jan 31, 2025
fmeum
requested review from
tjgq
and removed request for
tjgq,
a team and
katre
January 31, 2025 17:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
PR is awaiting review from an assigned reviewer
team-Configurability
platforms, toolchains, cquery, select(), config transitions
team-Performance
Issues for Performance teams
team-Remote-Exec
Issues and PRs for the Execution (Remote) team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #24808
RELNOTES: If the new
--file_write_strategy
flag is set tolazy
, files produced by file write actions (e.g. the ones produced byctx.actions.write
andctx.actions.expand_template
) are not written to disk with BwoB unless required by local execution or upon explicit request. The default iseager
, which retains the current behavior.