Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --file_write_strategy to Bazel #24921

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 14, 2025

Work towards #24808

RELNOTES: If the new --file_write_strategy flag is set to lazy, files produced by file write actions (e.g. the ones produced by ctx.actions.write and ctx.actions.expand_template) are not written to disk with BwoB unless required by local execution or upon explicit request. The default is eager, which retains the current behavior.

@fmeum fmeum force-pushed the 24808-file-write branch 4 times, most recently from afdfcd4 to b9c24bd Compare January 15, 2025 05:23
fmeum added 7 commits January 26, 2025 17:01
# Conflicts:
#	src/main/java/com/google/devtools/build/lib/actions/FileArtifactValue.java
#	src/main/java/com/google/devtools/build/lib/remote/AbstractActionInputPrefetcher.java
#	src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
� Conflicts:
�	src/main/java/com/google/devtools/build/lib/actions/cache/VirtualActionInput.java
�	src/main/java/com/google/devtools/build/lib/remote/merkletree/DirectoryTree.java
�	src/main/java/com/google/devtools/build/lib/remote/merkletree/MerkleTree.java
# Conflicts:
#	src/test/java/com/google/devtools/build/lib/actions/ActionCacheCheckerTest.java
#	src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java
@fmeum fmeum force-pushed the 24808-file-write branch 2 times, most recently from 2f96a9b to 323be9b Compare January 27, 2025 13:18
@fmeum fmeum changed the title Lazily write files with BwoB Add --file_write_strategy to Bazel Jan 28, 2025
@fmeum fmeum requested a review from tjgq January 31, 2025 17:04
@fmeum fmeum marked this pull request as ready for review January 31, 2025 17:04
@fmeum fmeum requested review from a team as code owners January 31, 2025 17:04
@fmeum fmeum requested review from katre and removed request for a team January 31, 2025 17:04
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Configurability platforms, toolchains, cquery, select(), config transitions team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 31, 2025
@fmeum fmeum requested review from tjgq and removed request for tjgq, a team and katre January 31, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant