Implement namespaced R classes #11385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not much progress here. Anyone willing to make a decision here? If Google isn't using these rules internally, maybe someone from the community can take over responsibility for reviews (but would require a Googler to merge)? |
|
It's been a while since there have been any updates here. Could someone make a call here? |
|
Any updates on this? |
ckolli5
added
the
awaiting-review
|
Closing this one in favor of the Starlark version of this issue: bazelbuild/rules_android#66 |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable rudimentary R class namespacing where each library only contains
references to the resources it declares instead of declarations plus all
transitive dependency references.
This basically implements the
android.namespacedRClass=trueGradle feature in Bazel.For our build this saves a total of 215MB outputs + 145 Actions for a clean build in addition to previous open PRs.
No resource merging for android_library targets
Smaller R.{class,txt}
Less desugaring + dexing