-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.1.0: Unrecognized VM option 'UseAllWindowsProcessorGroups' #25312
Comments
@meteorcloudy Looks like the compatibility trick doesn't work. We could require the latest patch version of the JDK or always ignore unknown VM options on Windows, not sure what's better. |
@bazel-io fork 8.1.1 |
@bazel-io fork 8.2.0 |
Requiring latest patch version of the JDK will break users running bazel_nojdk? I'm fine with always ignore unknown VM options on Windows |
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`. Fixes bazelbuild#25312 Closes bazelbuild#25342. PiperOrigin-RevId: 729186918 Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`. Fixes bazelbuild#25312 Closes bazelbuild#25342. PiperOrigin-RevId: 729186918 Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`. Fixes #25312 Closes #25342. PiperOrigin-RevId: 729186918 Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c Commit 6d64e2e Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
A fix for this issue has been included in Bazel 8.1.1 RC1. Please test out the release candidate and report any issues as soon as possible. |
Confirmed. Thanks!
|
Description of the bug:
When invoked on Windows w/ BellSoft Liberica 21.0.4, Bazel 8.1.0 chokes w/ the following:
Which category does this issue belong to?
No response
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
No response
Which operating system are you running Bazel on?
Windows Server 2022
What is the output of
bazel info release
?release 8.1.0-vmware
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.
12a3fc0
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
Enclosing
-XX:+UseAllWindowsProcessorGroups
in-XX:+IgnoreUnrecognizedVMOptions
and-XX:-IgnoreUnrecognizedVMOptions
doesn't appear to work as intended w/ BellSoft Liberica OpenJDK 21.0.4. It looks likeIgnoreUnrecognizedVMOptions
is processed out of band such that the-XX:+Ignore...
is immediately negated by-XX:-Ignore...
. (I only skimmed, but IIUC, the JVM launcher takes a separate pass over argv to look forIgnoreUnrecognizedVMOptions
and toggle a flag variable.)https://github.com/openjdk/jdk21u/blob/master/src/hotspot/share/runtime/arguments.cpp#L3620-L3692
The text was updated successfully, but these errors were encountered: