Skip to content

Commit

Permalink
Restore compatibility with any JDK 23 on Windows
Browse files Browse the repository at this point in the history
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`.

Fixes #25312

Closes #25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c
  • Loading branch information
fmeum authored and copybara-github committed Feb 20, 2025
1 parent 69511b3 commit 6d64e2e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/main/cpp/blaze.cc
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ static vector<string> GetServerExeArgs(const blaze_util::Path &jvm_path,
// https://bugs.openjdk.org/browse/JDK-6942632
result.push_back("-XX:+IgnoreUnrecognizedVMOptions");
result.push_back("-XX:+UseAllWindowsProcessorGroups");
result.push_back("-XX:-IgnoreUnrecognizedVMOptions");
#endif

if (startup_options.host_jvm_debug) {
Expand Down

0 comments on commit 6d64e2e

Please sign in to comment.