Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Tourney Admin #923

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fixes for Tourney Admin #923

merged 3 commits into from
Jan 24, 2025

Conversation

lowtorola
Copy link
Contributor

@lowtorola lowtorola commented Jan 24, 2025

  • altogether hides tournament matches for unreleased rounds, unless the user is staff or the matches are requested with external id private
  • adds link to django admin for private challonge bracket :)
  • fixes tournament match maps ordering with a lovely hack fix 😭
  • dont hide round maps if the user is staff
  • better error display in frontend when things go wrong (but not for initialize bc that is an asynchronous task)
  • actually list maps in admin page

Copy link
Member

@nour-massri nour-massri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to revert the no-staff filteration in serializler, need to debug this more

@nour-massri nour-massri merged commit 2dbd315 into main Jan 24, 2025
3 checks passed
@nour-massri nour-massri deleted the tourney-admin-fixes branch January 24, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants