Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "only allow scrimmages against reference player (revert later)… #741

Merged
merged 1 commit into from
Feb 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions backend/siarnaq/api/compete/test_views.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import io
import random
from datetime import timedelta
from unittest import skip
from unittest.mock import mock_open, patch

from django.test import TestCase, override_settings
Expand Down Expand Up @@ -1247,7 +1246,6 @@ def test_my_none(self):
self.assertEqual(len(response.json()["results"]), 1)


@skip("Skipping tests for forcing scrimmages against only reference player")
class ScrimmageRequestViewSetTestCase(APITransactionTestCase):
"""Test suite for the Scrimmage Requests API."""

Expand Down
4 changes: 0 additions & 4 deletions backend/siarnaq/api/compete/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from django.conf import settings
from django.db import NotSupportedError, transaction
from django.db.models import Exists, OuterRef, Q, Subquery
from django.http import HttpResponseForbidden
from django.utils import timezone
from drf_spectacular.utils import OpenApiParameter, OpenApiResponse, extend_schema
from rest_framework import mixins, status, viewsets
Expand Down Expand Up @@ -544,9 +543,6 @@ def create(self, request, *, episode_id):
serializer = self.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)

if serializer.validated_data["requested_to"].pk != 842:
return HttpResponseForbidden()

if serializer.validated_data["is_ranked"]:
active_statuses = {
SaturnStatus.CREATED,
Expand Down
6 changes: 0 additions & 6 deletions frontend/src/components/scrimmageRequestForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,6 @@ class ScrimmageRequestForm extends Component {
</button>
</div>
<div className="modal-body">
<p className="text-danger">
Note: only scrimmage requests against Reference Player are
allowed for now. This restriction is to enable our MIT class's
students to submit their bots to pass the class, and will be
removed after Friday.
</p>
<div className="form-group">
<label>Player order</label>
<select
Expand Down
Loading