Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(basti-cdk): unblock basti instance role update #118

Merged

Conversation

BohdanPetryshyn
Copy link
Collaborator

@BohdanPetryshyn BohdanPetryshyn commented Oct 24, 2024

Proposed Changes

This PR unblocks Basti instance IAM role update after a recent change that requires the role replacement by updating the role custom name. Similar vX prefixes will be added to other resources with custom names in the future as needed.

Related Issues/PRs

Reported in #117

Checklist

  • I cleaned up my code.
  • All the tests and checks passed (npm run test).
  • I have added necessary documentation and/or updated existing documentation.
  • I have added or modified tests to cover the changes.

Signed-off-by: Bohdan Petryshyn <b.y.petryshyn@gmail.com>
@BohdanPetryshyn BohdanPetryshyn force-pushed the fix-basti-cdk/unblock-basti-instance-role-update branch from f01e64a to 5388cc8 Compare October 24, 2024 03:39
@BohdanPetryshyn BohdanPetryshyn merged commit d83941b into main Oct 24, 2024
5 checks passed
@BohdanPetryshyn BohdanPetryshyn deleted the fix-basti-cdk/unblock-basti-instance-role-update branch October 24, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant