Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falsey config values are not persisted #134

Open
bschrag620 opened this issue Feb 13, 2025 · 0 comments · May be fixed by #133
Open

falsey config values are not persisted #134

bschrag620 opened this issue Feb 13, 2025 · 0 comments · May be fixed by #133

Comments

@bschrag620
Copy link

In an effort to keep our application.rb file as close to a default rails app as possible, we chose to configure console1984 in an initializer using a Rails.application.reloader.to_prepare block.

Rails.application.reloader.to_preparse do
  Rails.application.configure do
    config.console1984.incinerate = false
  end
end

What we found out though is that the falsey values are not persisted. The current behavior of set_from is such that not present values are not assigned. I've opened a PR that aligns the behavior of console1984 with the behavior in audits1984.

@bschrag620 bschrag620 linked a pull request Feb 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant