Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with Gramps' APIs instead of parsing Gramps XML #2444

Draft
wants to merge 1 commit into
base: 0.4.x
Choose a base branch
from
Draft

Integrate with Gramps' APIs instead of parsing Gramps XML #2444

wants to merge 1 commit into from
+2,058 −487

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Mar 14, 2025 •
edited
Loading

This fixes #1147 and this fixes #696 and this fixes #417

Blocked by

To do before merge

  • Ensure GrampsApiLoader.load_xml() is marked internal
  • remove the lxml, pycairo, and pygobject dependencies
  • remove the newly added temporary base classes and the old loader
  • Undo the changes to test.yml
  • make the new loader public (not internal)

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code labels Mar 14, 2025
@bartfeenstra bartfeenstra force-pushed the gramps-api branch 10 times, most recently from f7cbc5e to b2fb1bd Compare March 19, 2025 21:56
bartfeenstra
bartfeenstra commented Mar 19, 2025
View reviewed changes
bartfeenstra
bartfeenstra commented Mar 19, 2025
View reviewed changes
bartfeenstra
bartfeenstra commented Mar 19, 2025
View reviewed changes
betty/gramps/loader.py
pass

@abstractmethod
async def load_xml(self, xml: str) -> None:
Copy link
Owner Author

@bartfeenstra bartfeenstra Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this before merging

bartfeenstra
bartfeenstra commented Mar 19, 2025
View reviewed changes
@bartfeenstra bartfeenstra force-pushed the gramps-api branch 6 times, most recently from 143d927 to b1a77db Compare March 20, 2025 01:31
bartfeenstra
bartfeenstra commented Mar 20, 2025
View reviewed changes
bartfeenstra
bartfeenstra commented Mar 20, 2025
View reviewed changes
@bartfeenstra bartfeenstra force-pushed the gramps-api branch 3 times, most recently from 88a2ede to 591b8f0 Compare March 20, 2025 15:24
bartfeenstra
bartfeenstra commented Mar 20, 2025
View reviewed changes
bartfeenstra
bartfeenstra commented Mar 20, 2025
View reviewed changes
betty/gramps/loader.py
}


PluginMapping: TypeAlias = Mapping[
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract these factory changes into a separate PR

@bartfeenstra bartfeenstra force-pushed the gramps-api branch 6 times, most recently from 8decc7c to 6444586 Compare March 21, 2025 01:23
bartfeenstra
bartfeenstra commented Mar 21, 2025
View reviewed changes
betty/gramps/loader.py
for link_name, link_attributes in links_attributes.items():
if "url" not in link_attributes:
logger.warning(
self._localizer._(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure test coverage for all of these warnings

@bartfeenstra bartfeenstra force-pushed the gramps-api branch 5 times, most recently from 1fbb414 to f320563 Compare March 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Gramps APIs instead of parsing XML directly Validate Gramps XML Add a GEDCOM parser
1 participant
@bartfeenstra