Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify static translations #2043

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

bartfeenstra
Copy link
Owner

This fixes #2040

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Sep 28, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Sep 28, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review September 28, 2024 21:40
@bartfeenstra bartfeenstra force-pushed the simplify-static-translations branch from c5065dc to 27ad045 Compare September 29, 2024 17:00
@bartfeenstra bartfeenstra force-pushed the simplify-static-translations branch from 27ad045 to 1c0d0a5 Compare September 29, 2024 17:18
@bartfeenstra bartfeenstra merged commit d7a3d0e into 0.4.x Sep 29, 2024
6 checks passed
@bartfeenstra bartfeenstra deleted the simplify-static-translations branch September 29, 2024 17:30
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (35b3081) to head (1c0d0a5).
Report is 152 commits behind head on 0.4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##            0.4.x    #2043   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         341      341           
  Lines       20944    20944           
  Branches     3579     3579           
=======================================
  Hits        20410    20410           
  Misses        356      356           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove StaticTranslationsLocalizable's translations dump key
1 participant