Fix a bug where wait_to_thread() would await coroutines using the wrong event loops
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartfeenstra
added
bug
bartfeenstra
force-pushed
the
fix-wait-to-thread
branch
from
e3222ff to
f73cf4c
Compare
bartfeenstra
force-pushed
the
fix-wait-to-thread
branch
from
f73cf4c to
1a190f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #2037 +/- ##
==========================================
- Coverage 97.37% 97.36% -0.01%
==========================================
Files 343 343
Lines 20648 20674 +26
Branches 3573 3573
==========================================
+ Hits 20105 20130 +25
- Misses 354 355 +1
Partials 189 189 ☔ View full report in Codecov by Sentry. |
bartfeenstra
commented
Sep 26, 2024
| Wait for an awaitable in another thread. | ||
| """ | ||
| synced = _WaiterThread(f) | ||
| def wait_to_thread( |
There was a problem hiding this comment.
Extract this API change into a separate PR
bartfeenstra
force-pushed
the
fix-wait-to-thread
branch
from
2a58390 to
3fa79bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.